Change in vdsm[master]: jsonrpc: fd leak

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 1 18:40:10 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: jsonrpc: fd leak
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/45615/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: jsonrpc: fd leak
Line 8: 
Line 9: We need to make sure that there is no reference to objects which holds
Line 10: a socket because m2c closes socket when its object is garbage collected.
> Correct
Can you update the commit message to explain this clearly?
Line 11: 
Line 12: Bug-Url: https://bugzilla.redhat.com/1256446
Line 13: Change-Id: Ib15cca4659553b320babf928b603a0a75013ba99


-- 
To view, visit https://gerrit.ovirt.org/45615
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib15cca4659553b320babf928b603a0a75013ba99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list