Change in vdsm[master]: vm: Libvirt quering after disk detach operation addition.

fromani at redhat.com fromani at redhat.com
Tue Sep 1 11:42:30 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: Libvirt quering after disk detach operation addition.
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/45138/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 192: 
Line 193: class StorageUnavailableError(Exception):
Line 194:     pass
Line 195: 
Line 196: class Timeout(Exception):
> this is really unfortunate, because we have already virdomain.TimeoutError 
discard this, renaming Timeout as suggested below is good enough.
Line 197:     pass
Line 198: 
Line 199: class MissingLibvirtDomainError(Exception):
Line 200:     def __init__(self, reason=vmexitreason.LIBVIRT_DOMAIN_MISSING):


-- 
To view, visit https://gerrit.ovirt.org/45138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list