Change in vdsm[master]: vm: Libvirt quering after disk detach operation addition.

fromani at redhat.com fromani at redhat.com
Tue Sep 1 11:41:40 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: Libvirt quering after disk detach operation addition.
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/45138/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2601:         hooks.before_disk_hotunplug(driveXml, self.conf,
Line 2602:                                     params=drive.custom)
Line 2603:         try:
Line 2604:             self._dom.detachDevice(driveXml)
Line 2605:             self._waitForDriveRemoval(drive)
> Not a good idea, since _waitForDriveRemoval is polling libvirt, and this po
right, discard my comment here. Just rename too generic Timeout into HotunplugTimeout and leave the try/except handling as it is.
Line 2606:         except Timeout as e:
Line 2607:             self.log.error(e.message)
Line 2608:             return response.error('hotunplugDisk', e.message)
Line 2609:         except libvirt.libvirtError as e:


-- 
To view, visit https://gerrit.ovirt.org/45138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list