Change in vdsm[master]: vm.py: State saving in hotunplugDisk.

fromani at redhat.com fromani at redhat.com
Tue Sep 1 09:06:34 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm.py: State saving in hotunplugDisk.
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/45077/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2631:             return response.error('hotunplugDisk', e.message)
Line 2632:         else:
Line 2633:             self._devices[hwclass.DISK].remove(drive)
Line 2634: 
Line 2635:             # Find and remove disk device from vm's conf
> This patch is only about moving code around, I don't think this change shou
fair enough.
Line 2636:             for dev in self.conf['devices'][:]:
Line 2637:                 if (dev['type'] == hwclass.DISK and
Line 2638:                             dev['path'] == drive.path):
Line 2639:                     with self._confLock:


-- 
To view, visit https://gerrit.ovirt.org/45077
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list