Change in vdsm[master]: migration added migrateChangeParams verb

fromani at redhat.com fromani at redhat.com
Fri Oct 30 16:36:10 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: migration added migrateChangeParams verb
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

almost ok, one minor comment inside

https://gerrit.ovirt.org/#/c/46934/7/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 408:             self._raiseAbortError()
Line 409: 
Line 410:     def set_max_bandwidth(self, bandwidth):
Line 411:         self._vm.log.debug('setting migration max bandwidth to %d', bandwidth)
Line 412:         self._maxBandwidth = bandwidth
why is this needed?
Line 413:         self._vm._dom.migrateSetMaxSpeed(bandwidth)
Line 414: 
Line 415:     def stop(self):
Line 416:         # if its locks we are before the migrateToURI3()


-- 
To view, visit https://gerrit.ovirt.org/46934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52219c0e1f7d619dd30441dd4c70bd401f91e56d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list