Change in vdsm[master]: sampling: rename attributes for clarity

fromani at redhat.com fromani at redhat.com
Fri Oct 30 12:06:59 UTC 2015


Francesco Romani has uploaded a new change for review.

Change subject: sampling: rename attributes for clarity
......................................................................

sampling: rename attributes for clarity

VMBulkSampler has one ExpiringCache to track VMs/Domains believed
to be stuck, in order to avoid further clogging.
Due to an old mistake, the 'ttl' of this cache was set using a variable
named 'timeout'. The choice of names is unfortunate and source of
confusion.

This patch fixes that.

Change-Id: Ida543cf6f41e6e7a0b99277eb447117115fb4df1
Rename-Only: yes
Backport-To: 3.6
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/47893/1

diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 68d8330..fca36c9 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -475,17 +475,17 @@
 # a multiple of known timeout and period:
 # - vm sampling period is 15s (we control that)
 # - libvirt (default) qemu monitor timeout is 30s (we DON'T contol this)
-_TIMEOUT = 40.0
+_TTL = 40.0
 
 
 class VMBulkSampler(object):
     def __init__(self, conn, get_vms, stats_cache,
-                 stats_flags=0, timeout=_TIMEOUT):
+                 stats_flags=0, ttl=_TTL):
         self._conn = conn
         self._get_vms = get_vms
         self._stats_cache = stats_cache
         self._stats_flags = stats_flags
-        self._skip_doms = ExpiringCache(timeout)
+        self._skip_doms = ExpiringCache(ttl)
         self._sampling = threading.Semaphore()  # used as glorified counter
         self._log = logging.getLogger("virt.sampling.VMBulkSampler")
 


-- 
To view, visit https://gerrit.ovirt.org/47893
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida543cf6f41e6e7a0b99277eb447117115fb4df1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list