Change in vdsm[master]: net: fake sriov device hook
danken at redhat.com
danken at redhat.com
Thu Oct 29 15:19:43 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: net: fake sriov device hook
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/47847/2/vdsm_hooks/fakesriov/after_hostdev_list_by_caps.py
File vdsm_hooks/fakesriov/after_hostdev_list_by_caps.py:
Line 22: import hooking
Line 23:
Line 24: _FAKE_SRIOV = {
Line 25: # sriov device
Line 26: 'pci_0000_02_00_0': {
can you use fancier PCI addresses (say, bus 22 instead of 02) so there is a lesser chance we would collide with a true device on a true host?
Line 27: 'params': {
Line 28: 'address': {'bus': '2', 'domain': '0', 'function': '0',
Line 29: 'slot': '0'},
Line 30: 'capability': 'pci', 'iommu_group': '15',
Line 32: 'product': '82576 Gigabit Network Connection',
Line 33: 'product_id': '0x10e7', 'totalvfs': 7,
Line 34: 'vendor': 'Intel Corporation', 'vendor_id': '0x8086'}},
Line 35: # sriov net device
Line 36: 'net_enp2s0f0_78_e7_d1_e4_8f_16': {
same request applies to nic names.
Line 37: 'params': {
Line 38: 'capability': 'net', 'interface': 'enp2s0f0',
Line 39: 'parent': 'pci_0000_02_00_0'}},
Line 40: # vf1
Line 66: 'capability': 'net', 'interface': 'enp2s16f2',
Line 67: 'parent': 'pci_0000_02_10_2'}}}
Line 68:
Line 69: if __name__ == '__main__':
Line 70: host_devices = hooking.read_json()
people tend to install hooks automatically, and then complain that their host behaves in a silly way.
Please make this hook disabled by default (see https://gerrit.ovirt.org/43931 ) and add a little README file explaining for what is this hook good for (demoing and testing our new feature).
Line 71: host_devices.update(_FAKE_SRIOV)
--
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list