Change in vdsm[master]: service: change vdsm KillMode to mixed

ykaplan at redhat.com ykaplan at redhat.com
Thu Oct 29 14:01:56 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: service: change vdsm KillMode to mixed
......................................................................


Patch Set 6:

Yaniv,
If we set killmode to process: only the main process itself is killed.
Which means that we could end up with vdsm zombie children that won't be killed.

If we set killmode to mixed: 
the initial SIGTERM signal is sent to the main process (vdsm only). and after a delay if children processes still remain another signal this time: SIGKILL signal is sent to all remaining processes of the unit's control group.

This means that we get both benefits of using 'process' mode and 'control-group' mode.

First of all we systemd will termainate only vdsm.

If, after a delay, its children did not terminate on their own, then a SIGKILL will be sent to them.

This way we make sure no zombies are left.

I believe it is our best option.

-- 
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn at gmail.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list