Change in vdsm[master]: DynamicBridge: Log TypeError exceptions raised during dispatch

danken at redhat.com danken at redhat.com
Thu Oct 29 13:15:46 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: DynamicBridge: Log TypeError exceptions raised during dispatch
......................................................................


DynamicBridge: Log TypeError exceptions raised during dispatch

When dispatching via the DynamicBridge, the dispatched function may
raise a TypeError (typically due to a coding error).  Currently we
swallow the TypeError and raise InvalidCall instead.  This hides the
underlying problem making it harder to fix.  Keep the current behavior
but log the original exception too.

Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47546
Reviewed-by: Greg Padgett <gpadgett at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Adam Litke: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Greg Padgett: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list