Change in vdsm[master]: API: use modern locking around VM.destroy

danken at redhat.com danken at redhat.com
Thu Oct 29 11:24:55 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: API: use modern locking around VM.destroy
......................................................................


API: use modern locking around VM.destroy

cleanup a bit VM.destroy() without functional changes:

- log outside the lock
- use context managers for lock

Change-Id: I799b3b0d3e992df988efc6ab8e9263909062db0c
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42889
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/API.py
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/42889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I799b3b0d3e992df988efc6ab8e9263909062db0c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list