Change in vdsm[master]: vdsm: introduce cpuinfo module

fromani at redhat.com fromani at redhat.com
Thu Oct 29 09:49:30 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vdsm: introduce cpuinfo module
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

looks better and almost ready, I still lean toward explicit initialization. It is the only thing left IMO.

https://gerrit.ovirt.org/#/c/46912/10/lib/vdsm/cpuinfo.py
File lib/vdsm/cpuinfo.py:

Line 105:             else:
Line 106:                 _CPUS[cpu][key] = value
Line 107: 
Line 108: # Parse the cpuinfo right when module loads
Line 109: parse()
better in a way, worse into another. Can't we explicitely call parse() somewhere when we initialize the other subsystems?
Line 110: 
Line 111: 
Line 112: def arch(target_arch=None):
Line 113:     '''


-- 
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list