Change in vdsm[master]: vdscli: map invocation params to dictionary

ybronhei at redhat.com ybronhei at redhat.com
Wed Oct 28 07:13:57 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: vdscli: map invocation params to dictionary
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/45429/11/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 58:         return params
Line 59: 
Line 60:     def _callMethod(self, methodName, *args, **kwargs):
Line 61:         try:
Line 62:             method = _COMMAND_CONVERTER[methodName]
can't we use the schema instead of the hardcoded mapping that we do here? isn't that one of the reasons to have such schema file?
Line 63:         except KeyError as e:
Line 64:             raise Exception("Attempt to call function: %s with "
Line 65:                             "arguments: %s error: %s" %
Line 66:                             (methodName, args, e))


-- 
To view, visit https://gerrit.ovirt.org/45429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibac6eab3c519becb29d2b3551111d671bbb79df5
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list