Change in vdsm[master]: virt: enable libgfapi

nsoffer at redhat.com nsoffer at redhat.com
Wed Oct 28 00:04:42 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: virt: enable libgfapi
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/44061/7/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 317: 
Line 318:                 # The order of imgVolumesInfo is not guaranteed
Line 319:                 drive['volumeChain'] = res['imgVolumesInfo']
Line 320:                 drive['volumeInfo'] = res['info']
Line 321:                 if drive.get('diskType') == DISK_TYPE.NETWORK:
> I tried applying this patch on master but drive.get('diskType') is None for
We expect engine to send diskType="network" for gluster volumes, in the same way it send this value for ceph volumes.

The difference between ceph and gluster volumes is that engine sends also the protocol, hosts and path for ceph drives, but these are handled dynamically in vdsm for gluster volumes.

So this requires also a tiny engine patch.
Line 322:                     volinfo = res ['info']
Line 323:                     volPath = volinfo['path']
Line 324:                     drive['protocol'] = volinfo['protocol']
Line 325:                     # currently, single host is provided due to this bug:


-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list