Change in vdsm[ovirt-3.5]: Live Merge: Fix pre-extension calculation for chunked drives

nsoffer at redhat.com nsoffer at redhat.com
Mon Oct 26 19:03:16 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Live Merge: Fix pre-extension calculation for chunked drives
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/47589/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5937:         # to the drive capacity (plus cow overhead).  This was fixed in master
Line 5938:         # by commit d17dc8 but has not been backported.  Work around the
Line 5939:         # problem by capping it here.
Line 5940:         capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
Line 5941:         maxAlloc = min(capacity, maxAlloc)
Add qcow overhead:

    maxAlloc = maxAlloc * VOLWM_COW_OVERHEAD  # Add this constant from master

getNextVolumeSize will add 1GiB, but this is not enough for big disks.

With this we may end with maxVolumeSize + 1GiB, which is good enough.
Line 5942:         self.extendDriveVolume(drive, baseVolUUID, maxAlloc)
Line 5943: 
Line 5944:         # Trigger the collection of stats before returning so that callers
Line 5945:         # of getVmStats after this returns will see the new job


-- 
To view, visit https://gerrit.ovirt.org/47589
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I959608dc2f5a71afca605610267478e8a16e2c4b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list