Change in vdsm[master]: virt: periodic: factor out common code

mzamazal at redhat.com mzamazal at redhat.com
Mon Oct 26 16:56:08 UTC 2015


Milan Zamazal has posted comments on this change.

Change subject: virt: periodic: factor out common code
......................................................................


Patch Set 20: Code-Review-1

I'd prefer if virdomain.NotConnectedError change remained in a separate patch. It's actually not part of the refactoring as such and it's already clearly explained in the commit message that patches that benefit from the refactoring will follow.

-- 
To view, visit https://gerrit.ovirt.org/44548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I283331ecfa5b47c147f0a42cd4a6b51a49308fe7
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list