Change in vdsm[master]: stomp: make sure that subscriptions use uniqe id
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Mon Oct 26 12:26:42 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure that subscriptions use uniqe id
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/46656/3/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 139: return
Line 140:
Line 141: ack = frame.headers.get("ack", stomp.AckMode.AUTO)
Line 142: subscription = stomp._Subscription(dispatcher.connection, destination,
Line 143: sub_id, ack, None)
> not easier and better to raise exception here while you try to create the s
We check for existence of a key in line #136 and send ERROR frame to a client if there is one. We do not create _Subscription instance in this situation.
Line 144:
Line 145: self._sub_dests[destination].append(subscription)
Line 146: self._sub_ids[sub_id] = subscription
Line 147:
--
To view, visit https://gerrit.ovirt.org/46656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3883bb68134a6e2cc52cf54ce4027122db8150e9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list