Change in vdsm[ovirt-3.5]: takset: fix taskset and tests on python 2.6

fromani at redhat.com fromani at redhat.com
Mon Oct 26 11:54:56 UTC 2015


Francesco Romani has submitted this change and it was merged.

Change subject: takset: fix taskset and tests on python 2.6
......................................................................


takset: fix taskset and tests on python 2.6

This patch fixes taskset and tests to work properly on python 2.6.

Issues:
- In python 2.6 we don't have int.bit_length(),
  so we need to workaround it to make taskset.get() work.
- in python 2.7 threading.Event().wait() return the value of the Event,
  while always returned None in python <= 2.6.

These mistakes gone unnoticed because:
- the rpm build step still doesn't run tests, so deploy on EL6
  was succesfull
- the affected bits are used only in tests, and the
  real production code actually works.

Change-Id: I7621a1443367bfead7b953df5218dea24bf8095a
Bug-Url: https://bugzilla.redhat.com/1267851
Label: ovirt-3.5-only
Bug-Url: https://bugzilla.redhat.com/1265205
Related-To: https://bugzilla.redhat.com/1247075
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47013
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M lib/vdsm/taskset.py
M tests/tasksetTests.py
2 files changed, 24 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Francesco Romani: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7621a1443367bfead7b953df5218dea24bf8095a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list