Change in vdsm[master]: migration: Add migrateChangeGlobalParams verb

mbetak at redhat.com mbetak at redhat.com
Mon Oct 26 00:59:30 UTC 2015


Martin Betak has posted comments on this change.

Change subject: migration: Add migrateChangeGlobalParams verb
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/47409/6/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 160: 
Line 161:     return decorator
Line 162: 
Line 163: 
Line 164: class DynamicSemaphore(threading._Semaphore):
> We learned the hard way from the cpopen saga that messing with python imple
another alternative would be to implement our own semaphore that would support this feature (as opposed to wrapping/inheriting from Python's)

please see patch set 7 for my implementation of DynamicBoundedSemaphore
Line 165:     """
Line 166:     Extends standard semaphore with the ability to alter the current "bound"
Line 167:     by external actors.
Line 168: 


-- 
To view, visit https://gerrit.ovirt.org/47409
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6d1bcdc29f144d9fcf28a085b7014127cc4f41
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list