Change in vdsm[master]: net: SRIOV API change.

danken at redhat.com danken at redhat.com
Sun Oct 25 11:48:49 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: SRIOV API change.
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/47618/7/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:

Line 152:         if self.sndbufParam:
Line 153:             tune = iface.appendChildWithArgs('tune')
Line 154:             tune.appendChildWithArgs('sndbuf', text=self.sndbufParam)
Line 155: 
Line 156:         if 'inbound' in self.specParams or 'outbound' in self.specParams:
unrelated change - please postpone to its own patch if you are rebasing again.
Line 157:             iface.appendChild(self.paramsToBandwidthXML(self.specParams))
Line 158: 
Line 159:         return iface
Line 160: 


-- 
To view, visit https://gerrit.ovirt.org/47618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689629380996e5615f41e5705fa1f8fb322e0214
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list