Change in vdsm[master]: storage: file: removing SP assumtion on getImagesList

stirabos at redhat.com stirabos at redhat.com
Fri Oct 23 07:18:24 UTC 2015


Simone Tiraboschi has uploaded a new change for review.

Change subject: storage: file: removing SP assumtion on getImagesList
......................................................................

storage: file: removing SP assumtion on getImagesList

Removing SP assumtion on getImagesList to avoid it raising
if called on unconnected storageDomains

Change-Id: I8a4c4cd7a382bd4c9a2168f39022922f24891635
Bug-Url: https://bugzilla.redhat.com/1274622
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M vdsm/storage/fileSD.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/47676/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index dc4a68e..9d2e65a 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -300,10 +300,12 @@
         Fetch the set of the Image UUIDs in the SD.
         """
         # Get Volumes of an image
+        pools = self.getPools()
+        pool = pools[0] if pools else sd.BLANK_UUID
         pattern = os.path.join(sd.storage_repository,
                                # ISO domains don't have images,
                                # we can assume single domain
-                               self.getPools()[0],
+                               pool,
                                self.sdUUID, sd.DOMAIN_IMAGES)
         pattern = os.path.join(pattern, constants.UUID_GLOB_PATTERN)
         files = self.oop.glob.glob(pattern)


-- 
To view, visit https://gerrit.ovirt.org/47676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a4c4cd7a382bd4c9a2168f39022922f24891635
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>


More information about the vdsm-patches mailing list