Change in vdsm[ovirt-3.5]: vm: Libvirt quering after disk detach operation addition.

nsoffer at redhat.com nsoffer at redhat.com
Thu Oct 22 19:35:51 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: Libvirt quering after disk detach operation addition.
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Please verify on rhel 7 and rhel 6.

https://gerrit.ovirt.org/#/c/47629/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-10-22 11:32:41 +0300
Line 6: 
Line 7: vm: Libvirt quering after disk detach operation addition.
Line 8: 
Line 9: As stated in libvirt documentary, after detaching a device using
> nit: documentation?
I agree, but this is a backport.
Line 10: virDomainDetachDeviceFlags, we need to verify that this device
Line 11: has actually been detached.
Line 12: 
Line 13: Currently we use virDomainDetachDevice. However- That function behaves


https://gerrit.ovirt.org/#/c/47629/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4130:         Currently we use virDomainDetachDevice. However- That function behaves
Line 4131:         the same in that matter. (Currently it is not documented at libvirt's
Line 4132:         API docs- but after contacting libvirt's guys it turned out that this
Line 4133:         is true. Bug 1257280 opened for fixing the documentation.)
Line 4134:         TODO: remove this comment when the documentation will be fixed.
> this seems a copy/paste of the commit message. It is on itself correct, but
Again, this is a backport, lets keep it as is.
Line 4135: 
Line 4136:         :param drive: The drive that should be detached.
Line 4137:         """
Line 4138:         self.log.debug("Waiting for hotunplug to finish")


-- 
To view, visit https://gerrit.ovirt.org/47629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list