Change in vdsm[master]: log: failure in logging

nsoffer at redhat.com nsoffer at redhat.com
Thu Oct 22 17:00:00 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: log: failure in logging
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/47522/4/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 137:     # Override asyncore.dispatcher logging to use our logger
Line 138:     log = _log.debug
Line 139: 
Line 140:     def log_info(self, message, type='info'):
Line 141:         level = getattr(logging, type.upper(), None)
> I would map the type to our logger types instead of this check
Python cannot call this method with our logger types, so only the standard log levels should be supported.

This code is not for us; we will never call it. It is to get Python logging calls to use our logging system, instead of the pointless prints that we have now (look in asyncore.py).
Line 142:         if not isinstance(level, int):
Line 143:             raise ValueError('Invalid log level: %s' % type)
Line 144:         self._log.log(level, message)
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/47522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2396d1ec98987064134af334ff0a2a4dab78d836
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list