Change in vdsm[master]: net: SRIOV API change.

mpolednik at redhat.com mpolednik at redhat.com
Thu Oct 22 11:42:46 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: net: SRIOV API change.
......................................................................


Patch Set 6:

(1 comment)

Also, the API (rpc/vdsmapi-schema.json) is not updated - the 'hostdev' (which I'd really rather call device_name) is sent from engine right?

https://gerrit.ovirt.org/#/c/47618/6/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:

Line 98:              </bandwidth>]
Line 99:         </interface>
Line 100: 
Line 101:         -- or -- a slightly different SR-IOV network interface
Line 102:         <interface type='hostdev' managed='no'>
> (also seen previously in the change)
The type is gathered from 'device' attribute it seems.
Line 103:           <driver name='vfio'/>
Line 104:           <source>
Line 105:            <address type='pci' domain='0x0000' bus='0x00' slot='0x07'
Line 106:            function='0x0'/>


-- 
To view, visit https://gerrit.ovirt.org/47618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689629380996e5615f41e5705fa1f8fb322e0214
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list