Change in vdsm[master]: net: SRIOV API change.
mpolednik at redhat.com
mpolednik at redhat.com
Thu Oct 22 11:32:47 UTC 2015
Martin Polednik has posted comments on this change.
Change subject: net: SRIOV API change.
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Some little naming issue and exception that may or may not justify it's existence, but I'm OK with the general idea (actually quite happy to follow the [imho broken] libvirt model). One thing to note is that I'd really like you to test it with standard hostdev as to not introduce some evil regression (beyond unitTests).
https://gerrit.ovirt.org/#/c/47618/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1257: except hostdev.NoIOMMUSupportException:
Line 1258: self.log.exception('Could not reattach device %s back to host '
Line 1259: 'due to missing IOMMU support.')
Line 1260:
Line 1261: def _passthrough_host_devices(self):
_host_devices, without the passthrough
Line 1262: for device in self._devices[hwclass.HOSTDEV]:
Line 1263: yield device
Line 1264: for device in self._devices[hwclass.NIC]:
Line 1265: if device.is_hostdevice:
https://gerrit.ovirt.org/#/c/47618/6/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:
Line 28:
Line 29: class Interface(Base):
Line 30: __slots__ = ('nicModel', 'macAddr', 'network', 'bootOrder', 'address',
Line 31: 'linkActive', 'portMirroring', 'filter',
Line 32: 'sndbufParam', 'driver', 'name', 'vlanId', 'hostdev',
I'm not exactly happy with the 'hostdev' name as you could simply use device_name, host_device_name or something a bit more accurate. As I'm not directly related to this code, your call. :)
Line 33: 'is_hostdevice')
Line 34:
Line 35: def __init__(self, conf, log, **kwargs):
Line 36: # pyLint can't tell that the Device.__init__() will
Line 173: attrs = dict((key, str(value)) for key, value in elem.items())
Line 174: bandwidth.appendChildWithArgs(key, **attrs)
Line 175: return bandwidth
Line 176:
Line 177: def detach(self):
Not 100 % sure that this is needed as detach_detachable would fail e.g.
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 4182, in nodeDeviceLookupByName
if ret is None:raise libvirtError('virNodeDeviceLookupByName() failed', conn=self)
libvirt.libvirtError: Node device not found: no node device with matching name 'test'
Line 178: """
Line 179: Detach the device from the host. This method *must* be
Line 180: called before getXML in order to populate _deviceParams.
Line 181: """
--
To view, visit https://gerrit.ovirt.org/47618
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I689629380996e5615f41e5705fa1f8fb322e0214
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list