Change in vdsm[master]: tests: v2v: add test for commit f8127d8

fromani at redhat.com fromani at redhat.com
Thu Oct 22 08:00:11 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: tests: v2v: add test for commit f8127d8
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/47367/3/tests/v2vTests.py
File tests/v2vTests.py:

Line 99:         pass
Line 100: 
Line 101:     def listAllDomains(self):
Line 102:         if self._vms:
Line 103:             return self._vms
> Why not have one mechanism for returning fake vm info?
Probably easier and nicer this way. Will do that.
Line 104:         return [VmMock(*spec) for spec in self._vmspecs]
Line 105: 
Line 106:     def storageVolLookupByPath(self, name):
Line 107:         return LibvirtMock.Volume()


-- 
To view, visit https://gerrit.ovirt.org/47367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38bd3c06df263bc208e1a8c8aa6c0081ebdc218d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list