Change in vdsm[master]: net: Add unittest for network device xml creation.

danken at redhat.com danken at redhat.com
Thu Oct 22 06:39:16 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: Add unittest for network device xml creation.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/47619/1/tests/interfaceTests.py
File tests/interfaceTests.py:

Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
2014-2015
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 67: @MonkeyClass(libvirtconnection, 'get', Connection)
Line 68: @MonkeyClass(hostdev, '_sriov_totalvfs', _fake_totalvfs)
Line 69: class HostdevCreationTests(XMLTestCase):
Line 70: 
Line 71:     _PCI_ADDRESS = {'slot': '0x02', 'bus': '0x01', 'domain': '0x0000',
drop unused
Line 72:                     'function': '0x0', 'type': 'pci'}
Line 73: 
Line 74:     _PCI_ADDRESS_XML = '<address bus="0x01" domain="0x0000" function="0x0" \
Line 75:         slot="0x02" type="pci"/>'


-- 
To view, visit https://gerrit.ovirt.org/47619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6e1a198d53aabb379fcaf8358b08a3599c627f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list