Change in vdsm[master]: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook

osvoboda at redhat.com osvoboda at redhat.com
Wed Oct 21 21:01:40 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook
......................................................................


Patch Set 1:

(1 comment)

One late answer from April.

https://gerrit.ovirt.org/#/c/39359/1/vdsm_hooks/ipv6/ipv6.py
File vdsm_hooks/ipv6/ipv6.py:

Line 33:     hooking.write_json(setup_nets_config)
Line 34: 
Line 35: 
Line 36: def _process_network(attrs):
Line 37:     for property_name in ('ipv6addrs', 'ipv6addr', 'ipv6gateway',
> how does it go? don't you need an ipv6gateway per ipv6 address?
Other than IPv6 source routing? It may come as an extension but let's go step by step. If I did not understand please specify the need for multiple (seemingly undistinguishable) gateways.
Line 38:                           'ipv6autoconf', 'dhcpv6'):
Line 39:         value = attrs['custom'].get(property_name)
Line 40:         if value is not None:
Line 41:             attrs[property_name] = value


-- 
To view, visit https://gerrit.ovirt.org/39359
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I722d0007840060cdccdb12e4fba2a2066f33c62f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list