Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests

fromani at redhat.com fromani at redhat.com
Wed Oct 21 20:47:00 UTC 2015


Francesco Romani has submitted this change and it was merged.

Change subject: tests: Fix unmount in mkimage tests
......................................................................


tests: Fix unmount in mkimage tests

These tests seem to fail too much lately. Inspecting the code reveal
that we use freeloop=True in mkimage, but do not use this flag in the
tests. This lead to consuming of all available loop devices, causing
later mount attempts to fail.

Change-Id: If68a378133757f86b534f65808b2212828d97228
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1267851
Reviewed-on: https://gerrit.ovirt.org/46336
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Petr Horáček <phoracek at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47038
Tested-by: Francesco Romani <fromani at redhat.com>
Continuous-Integration: Francesco Romani <fromani at redhat.com>
---
M tests/mkimageTests.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list