Change in vdsm[master]: service: change vdsm KillMode to mixed

ybronhei at redhat.com ybronhei at redhat.com
Wed Oct 21 12:51:09 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: service: change vdsm KillMode to mixed
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

https://gerrit.ovirt.org/#/c/45038/6//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: service: change vdsm KillMode to mixed
Line 8: 
Line 9: SIGTERM sent to vdsm, is sent to its child processes
Line 10: as well, disrupting vdsm from closing everything properly.
disturbing
Line 11: 
Line 12: Using mixed KillMode will send SIGTERM only to main vdsm
Line 13: service at first,
Line 14: sigkill will be sent to its children after a timeout.


Line 9: SIGTERM sent to vdsm, is sent to its child processes
Line 10: as well, disrupting vdsm from closing everything properly.
Line 11: 
Line 12: Using mixed KillMode will send SIGTERM only to main vdsm
Line 13: service at first,
I would add a link to http://www.freedesktop.org/software/systemd/man/systemd.kill.html
Line 14: sigkill will be sent to its children after a timeout.
Line 15: 
Line 16: This will allow vdsm to close everything properly.
Line 17: 


-- 
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn at gmail.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list