Change in vdsm[master]: net: Fix duplicate SR-IOV device reported by vdsm

mpolednik at redhat.com mpolednik at redhat.com
Wed Oct 21 11:31:06 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: net: Fix duplicate SR-IOV device reported by vdsm
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

I'd like a bit more caution on what we store in a conf - my understanding is that we may eventually want to reconstruct the VM using it - as far as I understand that wouldn't be possible by using interface element.

https://gerrit.ovirt.org/#/c/47518/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4461:                 duplicate_found = True
Line 4462:                 break
Line 4463:         if duplicate_found:
Line 4464:             self.conf['devices'] = [d for d in self.conf['devices']
Line 4465:                                     if d['device'] != device_name]
Ignoring the fact that we do yet another pass over conf['devices'], I fear that we lose very important information in this step - if we were to re-create the VM with conf information, it would be different. How difficult it is to use the hostdev element rather then interface? Are there any implications from network code?
Line 4466: 
Line 4467:     def _getUnderlyingMemoryDeviceInfo(self):
Line 4468:         """
Line 4469:         Obtain memory device info from libvirt.


-- 
To view, visit https://gerrit.ovirt.org/47518
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2092624d2b755fdeb40535159754cca0c9406ee2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list