Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

osvoboda at redhat.com osvoboda at redhat.com
Wed Oct 21 05:51:32 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
......................................................................


Patch Set 2: Verified+1

Tried creating a network with no IPv6 functionality and the representing bridge had disable_ipv6 turned on (and as a result, there was not even an IPv6 link-local address).

Two tests failed, 3 were skipped.

======================================================================
FAIL: testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(False) (functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/testlib.py", line 67, in wrapper
    return f(self, *args)
  File "/usr/share/vdsm/tests/testValidation.py", line 170, in wrapper
    return f(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 221, in wrapper
    func(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 2462, in testSetupNetworksEmergencyDevicesCleanupVlanOverwrite
    self.assertBondDoesntExist(BONDING_NAME)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 299, in assertBondDoesntExist
    '%s found unexpectedly' % bondName)
AssertionError: bond11 found unexpectedly
-------------------- >> begin captured logging << --------------------
root: INFO: Adding network test-network({'vlan': '27', 'nic': 'dummy_7rtUY', 'dhcpv6': False, 'mtu': '1500', 'bootproto': 'none', 'bridged': False, 'defaultRoute': False})
root: INFO: Adding bond11({'nics': ['dummy_GZ5qM', 'dummy_GhojC'], 'options': ''})
root: INFO: Adding network test-network({'vlan': '27', 'nic': 'dummy_7rtUY', 'dhcpv6': False, 'mtu': '1500', 'bootproto': 'none', 'bridged': False, 'defaultRoute': False})
root: INFO: Adding bond11({'nics': ['dummy_GZ5qM', 'dummy_GhojC'], 'options': ''})
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: test_keep_initial_bond_slaves_ip_config (functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 221, in wrapper
    func(*args, **kwargs)
  File "/usr/share/vdsm/tests/testValidation.py", line 105, in wrapper
    return f(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 2823, in test_keep_initial_bond_slaves_ip_config
    self.assertIn(IP_ADDRESS_AND_CIDR, ipv4addrs)
AssertionError: '192.0.2.1/24' not found in []
-------------------- >> begin captured logging << --------------------
root: DEBUG: /sbin/ip -4 addr add dev dummy_GZ5qM 192.0.2.1/24 (cwd None)
root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
root: DEBUG: /sbin/ip -6 addr add dev dummy_GZ5qM fdb3:84e5:4ff4:55e3::1/64 (cwd None)
root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
root: INFO: Adding bond11({'nics': ['dummy_GZ5qM', 'dummy_GhojC'], 'options': ''})
root: DEBUG: /sbin/ip addr flush dev dummy_GZ5qM scope global (cwd None)
root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
--------------------- >> end captured logging << ---------------------

-- 
To view, visit https://gerrit.ovirt.org/46983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154f22a5f59174d0e33235d252aa42e463760e04
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list