Change in vdsm[master]: DynamicBridge: Log TypeError exceptions raised during dispatch

nsoffer at redhat.com nsoffer at redhat.com
Wed Oct 21 00:23:18 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: DynamicBridge: Log TypeError exceptions raised during dispatch
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/47546/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 33
Line 34
Line 35
Line 36
Line 37
Not related


Line 279
Line 280
Line 281
Line 282
Line 283
The right fix would to to remove the InvalidCall - it was useful when we started the jsonrpc work, but now it only hides the real error.

I would log here fn and methodArgs, in the same way they are logged by InvalidCall, and raise the original error.


-- 
To view, visit https://gerrit.ovirt.org/47546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list