Change in vdsm[master]: ssl: runtime config to choose implementation

ybronhei at redhat.com ybronhei at redhat.com
Tue Oct 20 16:50:44 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
......................................................................


Patch Set 23: Code-Review-1

(1 comment)

please fix the constant name

https://gerrit.ovirt.org/#/c/44689/23/debian/rules
File debian/rules:

Line 32: 		REBOOT_PATH=/sbin/reboot \
Line 33: 		SERVICE_PATH=/usr/sbin/service
Line 34: 
Line 35: override_dh_auto_build:
Line 36: 		sed -i -e 's/@SSl_IMPLEMENTATION@/ssl/g' lib/vdsm/config.py
> why is  '@SSl_IMPLEMENTATION@' not all capital letters?
nice catch :)
Line 37: 		dh_auto_build
Line 38: 
Line 39: destdir = debian/tmp
Line 40: 


-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list