Change in vdsm[master]: tests: Fix too delicate timings

danken at redhat.com danken at redhat.com
Tue Oct 20 10:33:55 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Fix too delicate timings
......................................................................


tests: Fix too delicate timings

Executor slow tests were using racy timings which caused random
failures. Adjust the timing to give 0.1 threads 0.1 second to finish.

We should replace the timeouts with events to make the tests
faster and less fragile.

Change-Id: Ib8890bffcaffafacaa6ec4a3e516a19793096f2d
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47442
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M tests/executorTests.py
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/47442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8890bffcaffafacaa6ec4a3e516a19793096f2d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list