Change in vdsm[master]: vdsm: introduce cpuinfo module

mpolednik at redhat.com mpolednik at redhat.com
Tue Oct 20 09:39:13 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: vdsm: introduce cpuinfo module
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/46912/9/lib/vdsm/cpuinfo.py
File lib/vdsm/cpuinfo.py:

Line 28: class Architecture:
Line 29:     X86_64 = 'x86_64'
Line 30:     PPC64 = 'ppc64'
Line 31:     PPC64LE = 'ppc64le'
Line 32:     POWER = (PPC64, PPC64LE)
> You have the same information 3 times. This should appear once, either as t
Dynamically generating the names will lead to loss of type information - e.g.

    _CPU_ARCH_TO_ARCHITECTURE['x86_64'] != Architecture.X86_64

as it is a string,
CPU_MAP is a cpu_map.xml file in libvirt, I'll add a comment.
Line 33: 
Line 34: 
Line 35: _CPU_ARCH_TO_ARCHITECTURE = {
Line 36:     'x86_64': Architecture.X86_64,


-- 
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list