Change in vdsm[master]: net: qos: change top qos api

danken at redhat.com danken at redhat.com
Mon Oct 19 21:16:28 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: qos: change top qos api
......................................................................


net: qos: change top qos api

Qos top api calls, configure_outbound and remove_outbound now take a
name of a physical device and a vlan_tag (that can be None). this
removes network object related code out of qos specific code and
simplifies unit testing.

Change-Id: Ie9c671cb0cf4b5e2e67b90861e2018c90f0f95f8
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45526
Reviewed-by: Ondřej Svoboda <osvoboda at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/tcTests.py
M vdsm/network/configurators/__init__.py
M vdsm/network/configurators/qos.py
3 files changed, 18 insertions(+), 21 deletions(-)

Approvals:
  Ido Barkan: Verified
  Ondřej Svoboda: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45526
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9c671cb0cf4b5e2e67b90861e2018c90f0f95f8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list