Change in vdsm[master]: register: Pull some vars into the class

danken at redhat.com danken at redhat.com
Mon Oct 19 08:30:34 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: register: Pull some vars into the class
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/46977/1/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:

Line 34: from vdsm.utils import getHostUUID, tobool
Line 35: 
Line 36: 
Line 37: class Register(object):
Line 38:     ca_dir = "/etc/pki/ovirt-engine/"
use ALLCAPS for class constants.
Line 39:     VDSM_ID_FILE = "/etc/vdsm/vdsm.id"
Line 40: 
Line 41:     def __init__(self, engine_fqdn, engine_https_port=None,
Line 42:                  fingerprint=None, ssh_port=None,


Line 35: 
Line 36: 
Line 37: class Register(object):
Line 38:     ca_dir = "/etc/pki/ovirt-engine/"
Line 39:     VDSM_ID_FILE = "/etc/vdsm/vdsm.id"
Please use

 vdsm.constants.P_VDSM_NODE_ID

instead
Line 40: 
Line 41:     def __init__(self, engine_fqdn, engine_https_port=None,
Line 42:                  fingerprint=None, ssh_port=None,
Line 43:                  ssh_user=None, check_fqdn=True,


-- 
To view, visit https://gerrit.ovirt.org/46977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1601ec61a30971f175630013023e8be2de77da17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list