Change in vdsm[master]: netinfo: rework reporting of DHCPv4/6 on network devices

ibarkan at redhat.com ibarkan at redhat.com
Sun Oct 18 11:22:25 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/46430/9/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 582: 
Line 583:     return updated_networking
Line 584: 
Line 585: 
Line 586: def _update_nested_dict(original, replacement):
> Basically, we're dealing here with 4 subdictionaries (bondings={}, bridges=
it is not about shorter, reusable code, here. I do appreciate those. It is about the readability.
Could you try and prepare the 'dirty' version? we can always be disgusted later and revert back to this cute recursion.
Line 587:     """
Line 588:     Use a replacement dict's fields in two ways: if a value is a dictionary,
Line 589:     update it recursively. Otherwise replace the value (e.g. a string).
Line 590:     """


-- 
To view, visit https://gerrit.ovirt.org/46430
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list