Change in vdsm[master]: register: handle non uuid machines

danken at redhat.com danken at redhat.com
Sat Oct 17 17:01:48 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: register: handle non uuid machines
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/47385/1/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:

Line 257:             self.uuid = self.vdsm_uuid
Line 258:         else:
Line 259:             uuid_node = getHostUUID(legacy=False)
Line 260:             if uuid_node is None:
Line 261:                 self.logger.debug("Collecting random UUID from system")
use uuid.uuid4() instead.

But more importantly, I don't know why we should fix this bug. It has been an intentional semantics to request user intervention for such hosts, hasn't it?

What's the 3.5 behavior?
Line 262:                 random_uuid_path = '/proc/sys/kernel/random/uuid'
Line 263:                 if os.path.exists(random_uuid_path):
Line 264:                     with open(random_uuid_path, 'r') as f:
Line 265:                         self.uuid = f.readline().strip()


-- 
To view, visit https://gerrit.ovirt.org/47385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9429e46895a73178cf459d5ced5d39499e993922
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list