Change in vdsm[master]: multipath: Fix multipath.conf selinux labels

danken at redhat.com danken at redhat.com
Sat Oct 17 10:05:04 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: multipath: Fix multipath.conf selinux labels
......................................................................


multipath: Fix multipath.conf selinux labels

When configuring multipath.conf, we were leaving multipath.conf with
incorrect selinux label:

    # ls -z /etc/multipath.conf
    -rw-r--r--. root root unconfined_u:object_r:etc_t:s0 /etc/multipath.conf

Now we restore the default selinux context on the temporary file before
renaming, so the final selinux labels are:

    # ls -z /etc/multipath.conf
    -rw-r--r--. root root system_u:object_r:etc_t:s0 /etc/multipath.conf

Due to a bug in libselinux python bindings [1], we set the label only if
selinux is enabled. This bug is fixed in upstream now.

[1] https://bugzilla.redhat.com/1264701

Change-Id: Id0aebae46f30abf908a8f48c4f1f2257394fe616
Backport-To: 3.6?
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/46398
Reviewed-by: Fabian Deutsch <fabiand at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/configurators/multipath.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Fabian Deutsch: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46398
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0aebae46f30abf908a8f48c4f1f2257394fe616
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fdeutsch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list