Change in vdsm[master]: guest-agent: desktopLock call failure is enough to be debug

nsoffer at redhat.com nsoffer at redhat.com
Fri Oct 16 21:29:02 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: guest-agent: desktopLock call failure is enough to be debug
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/47404/1/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 373:         try:
Line 374:             self.log.debug("desktopLock called")
Line 375:             self._forward("lock-screen")
Line 376:         except:
Line 377:             self.log.debug("desktopLock failed")
Any error is expected?!

I think we need a more specific exception handler. Expected errors can be logged in debug level, but unexpected probably need more attention.
Line 378: 
Line 379:     def desktopLogin(self, domain, user, password):
Line 380:         try:
Line 381:             self.log.debug("desktopLogin called")


-- 
To view, visit https://gerrit.ovirt.org/47404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd032471396a97999c2cea5c88ae04ec8ca4028
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list