Change in vdsm[master]: betterAsyncore: Override asyncore logging to use our logger

danken at redhat.com danken at redhat.com
Fri Oct 16 21:05:38 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: betterAsyncore: Override asyncore logging to use our logger
......................................................................


betterAsyncore: Override asyncore logging to use our logger

asyncore.dispatcher is using its own logging subsystem writing to stderr
or to stdout, which is useless in a daemon environment when both
descriptors are redirected to /dev/null.

This patch overrides the logging function so they write to our logger.

Tested using the shell:

    >>> import logging
    >>> logging.basicConfig(level=logging.DEBUG)
    >>> from yajsonrpc.betterAsyncore import Dispatcher
    >>> d = Dispatcher()
    >>> d.log("foo")
    DEBUG:vds.dispatcher:foo
    >>> d.log_info("foo")
    INFO:vds.dispatcher:foo

Change-Id: I7a75570b6e456d1e5643a3baf44570f23ea3c02e
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47407
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/47407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a75570b6e456d1e5643a3baf44570f23ea3c02e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list