Change in vdsm[master]: migration: Add retry logic for incoming limit

mbetak at redhat.com mbetak at redhat.com
Fri Oct 16 15:46:28 UTC 2015


Martin Betak has posted comments on this change.

Change subject: migration: Add retry logic for incoming limit
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/46971/9/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 350:                     SourceThread._ongoingMigrations.release()
Line 351:                     # the destination is busy with incoming migrations
Line 352:                     # release semaphore and give other outgoing migrations
Line 353:                     # a chance
Line 354:                     time.sleep(5)
> A few questions pop to mind, and we need to figure them out before to commi
Well there are 3 main preparations I see in run()
1) _setupVdsConnection() -which we probably want to call only once (unless it can time-out)

2) _setupRemoteMachineParams() - which depends on _dom.XMLDesc(0) which I'm not sure can change during retries

3) _prepareGuest() - which in migration case (not hibernation) just outputs stat is started we want to do this probably at most once

Regarding the permitted operations: I think only migrateCancel should be allowed and we enable this by checking the _migrationCanceledEvt in the retry loop.
Line 355:                     SourceThread._ongoingMigrations.acquire()
Line 356:                 else:
Line 357:                     break
Line 358: 


-- 
To view, visit https://gerrit.ovirt.org/46971
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icabe79dfccb61ce43489a9a242a5390e73979649
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list