Change in vdsm[master]: betterAsyncore: Override asyncore logging to use our logger

nsoffer at redhat.com nsoffer at redhat.com
Fri Oct 16 14:41:52 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: betterAsyncore: Override asyncore logging to use our logger
......................................................................

betterAsyncore: Override asyncore logging to use our logger

asyncore.dispatcher is using its own logging subsystem writing to stderr
or to stdout, which is useless in a daemon environment when both
descriptors are redirected to /dev/null.

This patch overrides the logging function so they write to our logger.

Tested using the shell:

    >>> import logging
    >>> logging.basicConfig(level=logging.DEBUG)
    >>> from yajsonrpc.betterAsyncore import Dispatcher
    >>> d = Dispatcher()
    >>> d.log("foo")
    DEBUG:vds.dispatcher:foo
    >>> d.log_info("foo")
    INFO:vds.dispatcher:foo

Change-Id: I7a75570b6e456d1e5643a3baf44570f23ea3c02e
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/47407/1

diff --git a/lib/yajsonrpc/betterAsyncore.py b/lib/yajsonrpc/betterAsyncore.py
index 6edfdd2..ab292be 100644
--- a/lib/yajsonrpc/betterAsyncore.py
+++ b/lib/yajsonrpc/betterAsyncore.py
@@ -151,6 +151,10 @@
         else:
             return getattr(asyncore.dispatcher, name)(self)
 
+    # Override asyncore.dispatcher logging to use our logger
+    log = _log.debug
+    log_info = _log.info
+
 
 class AsyncoreEvent(asyncore.file_dispatcher):
     def __init__(self, map=None):


-- 
To view, visit https://gerrit.ovirt.org/47407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a75570b6e456d1e5643a3baf44570f23ea3c02e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list