Change in vdsm[master]: hsm: Remove support for size in sectors as int

danken at redhat.com danken at redhat.com
Fri Oct 16 06:41:44 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hsm: Remove support for size in sectors as int
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/47381/3/client/vdsClient.py
File client/vdsClient.py:

Line 1064
Line 1065
Line 1066
Line 1067
Line 1068
oh dear. I thought that current vdsClient sends strings. But it does not. I'd suspect that QE may have scripts with 

   vdsClient -s 0 createVolume <some-size>

somewhere.

:-(

I don't think that there's any real-life script like that, since we've objected vdsClient usage. Still, it might not be wise to introduce this to 3.6.


https://gerrit.ovirt.org/#/c/47381/3/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 67: 
Line 68: UUID_GLOB_PATTERN = '*-*-*-*-*'
Line 69: 
Line 70: MEGAB = 2 ** 20  # = 1024 ** 2 = 1 MiB
Line 71: GB = 1024 * MEGAB
Let's be prudent and call it GiB, like Système International d'Unités does.
Line 72: 
Line 73: #
Line 74: # Path definitions
Line 75: #


-- 
To view, visit https://gerrit.ovirt.org/47381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52957eec163973fd60a95a9bf523131f3c83a9da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list