Change in vdsm[master]: migration: Add retry logic for incoming limit

fromani at redhat.com fromani at redhat.com
Thu Oct 15 16:50:21 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: migration: Add retry logic for incoming limit
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/46971/9/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 350:                     SourceThread._ongoingMigrations.release()
Line 351:                     # the destination is busy with incoming migrations
Line 352:                     # release semaphore and give other outgoing migrations
Line 353:                     # a chance
Line 354:                     time.sleep(5)
A few questions pop to mind, and we need to figure them out before to commit to this approach.

can we assume all the preparation done in _run() before to get here is still valid after the next try?
Or do we want to redo it again, to be sure it is still valid?
Which operations can be performed on this VM while is retrying migrations?
Line 355:                     SourceThread._ongoingMigrations.acquire()
Line 356:                 else:
Line 357:                     break
Line 358: 


-- 
To view, visit https://gerrit.ovirt.org/46971
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icabe79dfccb61ce43489a9a242a5390e73979649
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list