Change in vdsm[master]: migration: Add incoming migration semaphore
fromani at redhat.com
fromani at redhat.com
Thu Oct 15 16:19:33 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
......................................................................
Patch Set 13: Code-Review-1
(1 comment)
-1 for visibility. The current patch looks ok, but not sure it is complete.
https://gerrit.ovirt.org/#/c/45954/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2759: usedTimeout = self._waitForUnderlyingMigration()
Line 2760: self._attachLibvirtDomainAfterMigration(
Line 2761: self._incomingMigrationFinished.isSet(), usedTimeout)
Line 2762: finally:
Line 2763: migration.incomingMigrations.release()
This is ok, but what if some exception is raised before to reach this? We should make sure to release incomingMigrations on the error path.
Line 2764: # else domain connection already established earlier
Line 2765: self._domDependentInit()
Line 2766: del self.conf['migrationDest']
Line 2767: hooks.after_vm_migrate_destination(self._dom.XMLDesc(0), self.conf)
--
To view, visit https://gerrit.ovirt.org/45954
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8952f732033ed160292b11fbc0c4deac099b2b3e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list