Change in vdsm[master]: storage: Initial size for thin provisioning disk

alitke at redhat.com alitke at redhat.com
Thu Oct 15 14:40:17 UTC 2015


Adam Litke has posted comments on this change.

Change subject: storage: Initial size for thin provisioning disk
......................................................................


Patch Set 8: Code-Review+2

(2 comments)

Some minor comments (ok for a separate patch later).

https://gerrit.ovirt.org/#/c/46417/8/tests/blockVolumeTests.py
File tests/blockVolumeTests.py:

Line 48:         # preallocate
Line 49:         [volume.PREALLOCATED_VOL],
Line 50:         [volume.SPARSE_VOL],
Line 51:         ])
Line 52:     def test_fail_invalide_block_volume_size(self, preallocate):
For another patch: s/invalide/invalid/
Line 53:         with self.assertRaises(se.InvalidParameterException):


https://gerrit.ovirt.org/#/c/46417/8/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 8287: #
Line 8288: # @initialSize:      #optional if specified, initial size of volume
Line 8289: #                    for thin provisioning on block storage.
Line 8290: #                    When using preallocated volumes or for file storage
Line 8291: #                    the initial size is ignored. In sectors
Is it still ignored, or does it cause an error?
Line 8292: #                    if sent as integer,in bytes if sent as string
Line 8293: #                    (new in version 4.17.8)
Line 8294: #
Line 8295: # Returns:


-- 
To view, visit https://gerrit.ovirt.org/46417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf5f142541bf0b311a77a0544a1c4ffb689a9fde
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list