Change in vdsm[master]: migration: Add incoming migration semaphore

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Oct 15 13:06:42 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: migration: Add incoming migration semaphore
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/45954/12/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 54: VIR_MIGRATE_PARAM_GRAPHICS_URI = 'graphics_uri'
Line 55: 
Line 56: incomingMigrations = threading.BoundedSemaphore(
Line 57:     min(config.getint('vars', 'max_incoming_migrations'),
Line 58:         caps.CpuTopology().cores()))
> Why minimum of these? We should honor the config setting since CPU count is
that's the same for outgoing...on small servers we don't allow more migrations than physical cores
Line 59: 
Line 60: 
Line 61: class MigrationDestinationSetupError(RuntimeError):
Line 62:     """


-- 
To view, visit https://gerrit.ovirt.org/45954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8952f732033ed160292b11fbc0c4deac099b2b3e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list