Change in vdsm[master]: Remove duplicate permissions checks

nsoffer at redhat.com nsoffer at redhat.com
Wed Oct 14 14:32:27 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Remove duplicate permissions checks
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/47300/2/tests/mkimageTests.py
File tests/mkimageTests.py:

Line 121:                 self._check_permissions(filepath,
Line 122:                                         ((stat.S_IRUSR, True),
Line 123:                                          (stat.S_IWUSR, True),
Line 124:                                          (stat.S_IXUSR, False)))
Line 125:                 self._check_permissions(filepath,
> the reason to move this code evades me. is it intentional? what's behind it
This is the common order of permissions - user, group, other.
Line 126:                                         ((stat.S_IRGRP, True),
Line 127:                                          (stat.S_IWGRP, False),
Line 128:                                          (stat.S_IXGRP, False)))
Line 129:                 self._check_permissions(filepath,


-- 
To view, visit https://gerrit.ovirt.org/47300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I897da2d7cd64d67081cea3b89c408c2081a91c76
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list